[cfe-commits] [patch][Windows] Fix 13761.

[r4start]

On 12/09/12 20:19, John McCall wrote:
> On Sep 12, 2012, at 3:51 AM, r4start wrote:
>> This patch is fix for this bug http://llvm.org/bugs/show_bug.cgi?id=13761.
> +  static bool NeedThisReturn(GlobalDecl GD);
>
> Please name this 'needsThisReturn'.
Done.
> Also, please leave the FIXMEs about "is base" in place;  those are still
> applicable (the flag is passed to constructors and destructors of classes
> with virtual bases).
As I remember this flag passes only in constructors.
> Otherwise this looks fine.  I can't remember if you can commit.
No, I can`t commit.


Also I change constructor check in 
CodeGenCXX/microsoft-abi-constructors.cpp to
full check of constructor body.

  - Dmitry Sokolov.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Fix13761.patch
Type: text/x-patch
Size: 6105 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120912/2ee2654f/attachment.bin>