[cfe-commits] [PATCH v2] Fixing some clang tests where ARM C++ ABI differs

David Blaikie dblaikie at gmail.com
Mon Sep 10 16:08:15 PDT 2012


On Mon, Sep 10, 2012 at 1:24 PM, John McCall <rjmccall at apple.com> wrote:
> On Sep 10, 2012, at 11:53 AM, David Blaikie wrote:
>> On Mon, Sep 10, 2012 at 11:41 AM, David Tweed <david.tweed at arm.com> wrote:
>>> ping on patch review status: the original submission did have a couple of
>>> issues pointed out in review, primarily because it wasn't quite the patch I
>>> intended to send. With the explanation of the alternating choice of triples
>>> and the correct patch sent, is this suitable for committing in order to fix
>>> those test failures on ARM?
>>
>> I had half a mind to wait for John to OK the alternating choices of
>> triples, but honestly that minor detail seems fine for post-commit
>> feedback if he feels strongly about it.
>
> I don't have any real problem with the alternating triples.
>
> John.

Committed as r163564.

Thanks for looking into this David, let me know if there's anything
else I (/we) can do to help get more those ARM bots to green.

- David



More information about the cfe-commits mailing list