[cfe-commits] [PATCH] libc++ visibility fixes

[Dimitry Andric]

On 2012-09-10 22:51, Dimitry Andric wrote:...
> In a follow-up post, I will attempt to do the same for when the first
> line of the testcase is #pragma GCC visibility push(hidden).  This leads
> to a whole bunch of other errors, which have only been partially solved
> by the fix for PR 13662.

So here's the follow-up already. :)  Since it doesn't make too much
sense to have a separate patch for the case of pushed hidden
visibility, I have just attached the complete version now.

This survives both testcases, with just a few warnings about hash_map
being deprecated:

   clang -std=c++11 -stdlib=libc++ -c libcxx-visibility-default-testcase.cpp
   clang -std=c++11 -stdlib=libc++ -c libcxx-visibility-hidden-testcase.cpp

Btw, I tried compiling these with -D_LIBCPP_DEBUG defined, but that
leads to quite a number of errors of the form:

   In file included from libcxx-visibility-hidden-testcase.cpp:2:
   In file included from /usr/include/c++/v1/algorithm:594:
   In file included from /usr/include/c++/v1/memory:596:
   /usr/include/c++/v1/iterator:1439:30: error: elaborated type refers to a typedef
       friend class _Container::__self;
                                ^
   /usr/include/c++/v1/regex:1144:28: note: in instantiation of template class 'std::__1::__debug_iter<std::__1::basic_string<char>, char *>' requested here
               __r.assign(__n.begin(), __n.end());
                              ^
   /usr/include/c++/v1/string:1043:58: note: declared here
       typedef typename basic_string                        __self;
                                                            ^

Any idea what is going on?  Is _LIBCPP_DEBUG currently broken?

-Dimitry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libcxx-visibility-3.diff
Type: text/x-diff
Size: 24745 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120910/a0d0af34/attachment.diff>
-------------- next part --------------
#pragma GCC visibility push(default)
#include <algorithm>
#include <array>
#include <atomic>
#include <bitset>
#include <cassert>
#include <ccomplex>
#include <cctype>
#include <cerrno>
#include <cfenv>
#include <cfloat>
#include <chrono>
#include <cinttypes>
#include <ciso646>
#include <climits>
#include <clocale>
#include <cmath>
#include <codecvt>
#include <complex>
#include <condition_variable>
#include <csetjmp>
#include <csignal>
#include <cstdarg>
#include <cstdbool>
#include <cstddef>
#include <cstdint>
#include <cstdio>
#include <cstdlib>
#include <cstring>
#include <ctgmath>
#include <ctime>
#include <cwchar>
#include <cwctype>
#include <deque>
#include <exception>
#include <ext/hash_map>
#include <ext/hash_set>
#include <forward_list>
#include <fstream>
#include <functional>
#include <future>
#include <initializer_list>
#include <iomanip>
#include <ios>
#include <iosfwd>
#include <iostream>
#include <istream>
#include <iterator>
#include <limits>
#include <list>
#include <locale>
#include <map>
#include <memory>
#include <mutex>
#include <new>
#include <numeric>
#include <ostream>
#include <queue>
#include <random>
#include <ratio>
#include <regex>
#include <scoped_allocator>
#include <set>
#include <sstream>
#include <stack>
#include <stdexcept>
#include <streambuf>
#include <string>
#include <strstream>
#include <system_error>
#include <thread>
#include <tuple>
#include <type_traits>
#include <typeindex>
#include <typeinfo>
#include <unordered_map>
#include <unordered_set>
#include <utility>
#include <valarray>
#include <vector>
-------------- next part --------------
#pragma GCC visibility push(hidden)
#include <algorithm>
#include <array>
#include <atomic>
#include <bitset>
#include <cassert>
#include <ccomplex>
#include <cctype>
#include <cerrno>
#include <cfenv>
#include <cfloat>
#include <chrono>
#include <cinttypes>
#include <ciso646>
#include <climits>
#include <clocale>
#include <cmath>
#include <codecvt>
#include <complex>
#include <condition_variable>
#include <csetjmp>
#include <csignal>
#include <cstdarg>
#include <cstdbool>
#include <cstddef>
#include <cstdint>
#include <cstdio>
#include <cstdlib>
#include <cstring>
#include <ctgmath>
#include <ctime>
#include <cwchar>
#include <cwctype>
#include <deque>
#include <exception>
#include <ext/hash_map>
#include <ext/hash_set>
#include <forward_list>
#include <fstream>
#include <functional>
#include <future>
#include <initializer_list>
#include <iomanip>
#include <ios>
#include <iosfwd>
#include <iostream>
#include <istream>
#include <iterator>
#include <limits>
#include <list>
#include <locale>
#include <map>
#include <memory>
#include <mutex>
#include <new>
#include <numeric>
#include <ostream>
#include <queue>
#include <random>
#include <ratio>
#include <regex>
#include <scoped_allocator>
#include <set>
#include <sstream>
#include <stack>
#include <stdexcept>
#include <streambuf>
#include <string>
#include <strstream>
#include <system_error>
#include <thread>
#include <tuple>
#include <type_traits>
#include <typeindex>
#include <typeinfo>
#include <unordered_map>
#include <unordered_set>
#include <utility>
#include <valarray>
#include <vector>