[cfe-commits] r163489 [1/2] - in /cfe/trunk: lib/StaticAnalyzer/Core/PathDiagnostic.cpp test/Analysis/retain-release.m

[NAKAMURA Takumi]

2012/9/10 Ted Kremenek <kremenek at apple.com>:
> Author: kremenek
> Date: Mon Sep 10 01:20:06 2012
> New Revision: 163489
>
> URL: http://llvm.org/viewvc/llvm-project?rev=163489&view=rev
> Log:
> Take another crack at stabilizing the emission order of analyzer
> diagnostics without using FoldingSetNodeIDs.  This is done
> by doing a complete recursive comparison of the PathDiagnostics.
>
> Note that the previous method of comparing FoldingSetNodeIDs did
> not end up relying on unstable things such as pointer addresses, so
> I suspect this may still have some issues on various buildbots because
> I'm not sure if the true source of non-determinism has been eliminated.
> The tests pass for me, so the only way to know is to commit this change
> and see what happens.
>
> Modified:
>     cfe/trunk/lib/StaticAnalyzer/Core/PathDiagnostic.cpp
>     cfe/trunk/test/Analysis/retain-release.m

Ted, it brought a failure on some hosts, x86_64-centos6-linux,
win32(s), ubuntu, freebsd...

...Takumi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: centos6.diff
Type: application/octet-stream
Size: 8051 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120910/b1a4b587/attachment.obj>