[cfe-commits] [libcxx] r163120 - in /libcxx/trunk: include/__undef_min_max src/stdexcept.cpp

[Richard Smith]

On Mon, Sep 3, 2012 at 11:13 AM, Howard Hinnant <hhinnant at apple.com> wrote:

> Author: hhinnant
> Date: Mon Sep  3 13:13:11 2012
> New Revision: 163120
>
> URL: http://llvm.org/viewvc/llvm-project?rev=163120&view=rev
> Log:
> Some minor mingw64 porting tweaks from Glen.
>
> Modified:
>     libcxx/trunk/include/__undef_min_max
>     libcxx/trunk/src/stdexcept.cpp
>
> Modified: libcxx/trunk/include/__undef_min_max
> URL:
> http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/__undef_min_max?rev=163120&r1=163119&r2=163120&view=diff
>
> ==============================================================================
> --- libcxx/trunk/include/__undef_min_max (original)
> +++ libcxx/trunk/include/__undef_min_max Mon Sep  3 13:13:11 2012
> @@ -9,11 +9,11 @@
>
>  //===----------------------------------------------------------------------===//
>
>  #ifdef min
> -#warning: macro min is incompatible with C++.  #undef'ing min
> +#warning: macro min is incompatible with C++.  #undefing min
>  #undef min
>  #endif
>
>  #ifdef max
> -#warning: macro max is incompatible with C++.  #undef'ing max
> +#warning: macro max is incompatible with C++.  #undefing max
>  #undef max
>  #endif
>

The colons in these #warnings make it into the diagnostic output (on both
clang and gcc), resulting in warnings like:

<stdin>:1:2: warning: : macro min is incompatible with C++.  #undefing min
[-W#warnings]

I would suggest taking them out.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120905/3f74a83a/attachment.html>