[cfe-commits] [PATCH] TableGen'ize documentation command lists (and break binary compatibility of CXComment)

Dmitri Gribenko gribozavr at gmail.com
Wed Sep 5 10:18:28 PDT 2012


On Wed, Sep 5, 2012 at 8:13 PM, Ted Kremenek <kremenek at apple.com> wrote:
> On Sep 5, 2012, at 10:09 AM, Matthieu Monrocq <matthieu.monrocq at gmail.com>
> wrote:
>
> If you need to break binary compatibility, I would encourage you to go all
> the way and make CXComment an opaque pointer. This way further changes will
> never again require breaking binary compatibility (for this).
>
>
> Agreed.  We have typically not exposed details of CX* data structures in the
> past that we wanted to extend over time.

Matthieu and Ted: thank you for the idea.  I was feeling the same way,
but Index.h has lots of structures with exposed internals (with a "do
not touch" warning for users).  I will rework the patch and resubmit.

Dmitri

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/



More information about the cfe-commits mailing list