[cfe-commits] [PATCH] cindex.py - Make the compatibility check in cindex.py explicit

Tobias Grosser tobias at grosser.es
Wed Sep 5 02:01:23 PDT 2012


Hi,

I would like to commit the attached patch. Here the intended
commit message:

----------------------
[cindex.py] Make the use of a compatibilty check explicit

At the moment, we implictly check compatibility between the python
bindings and libclang, as the python bindings will fail to load in case
a method we use in libclang is not available.

This patch makes the use of this compatibility check explicit and
introduces a flag to optionally disable the check. This will allow us to
further harden the compatibility check, but it also gives the user the
possibility to disable the compatibility check to evaluate compatibility
with older libclang versions.

I added documentation that makes clear the python bindings are only
tested with the libclang version they have been shipped with.
----------------------

Gregory raised in a recent discussion concerns about silently removing
the compatibility check. I took this as a motivation to make the check
even more explicit, but also introduced an option to disable it if
explicitly demanded. I hope this patch can cater both sides, the users
who want to experiment with multi-version compatibility and the users
who aim for an even stricter compatibility check.

OK to commit?

Tobi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-cindex.py-Make-the-use-of-a-compatibilty-check-expli.patch
Type: text/x-patch
Size: 4120 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120905/47eddca1/attachment.bin>


More information about the cfe-commits mailing list