[cfe-commits] r163113 - /cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td

[Chandler Carruth]

On Mon, Sep 3, 2012 at 6:41 AM, Joao Matos <ripzonetriton at gmail.com> wrote:

> Author: triton
> Date: Mon Sep  3 05:41:45 2012
> New Revision: 163113
>
> URL: http://llvm.org/viewvc/llvm-project?rev=163113&view=rev
> Log:
> Improved the warning for the #@ Microsoft charizing operator. The existing
> one misspelled the token as "@#" and didn't capitalize Microsoft.
>

Again, please get pre-commit review until you are certain you understand
the requirements to submit a patch directly.

Specifically, you need to include test cases for diagnostic changes like
this. Please add several, as we can't have had thorough coverage if this
didn't break any existing test cases.


> Modified:
>     cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td
>
> Modified: cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td?rev=163113&r1=163112&r2=163113&view=diff
>
> ==============================================================================
> --- cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td (original)
> +++ cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td Mon Sep  3
> 05:41:45 2012
> @@ -55,7 +55,7 @@
>
>  def ext_dollar_in_identifier : Extension<"'$' in identifier">,
>    InGroup<DiagGroup<"dollar-in-identifier-extension">>;
> -def ext_charize_microsoft : Extension<"@# is a microsoft extension">,
> +def ext_charize_microsoft : Extension<"charizing operator #@ is a
> Microsoft extension">,
>    InGroup<Microsoft>;
>
>  def ext_token_used : Extension<"extension used">,
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120904/4a12e981/attachment.html>