[cfe-commits] r163079 - /cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

[Chandler Carruth]

On Tue, Sep 4, 2012 at 9:42 AM, Nico Weber <thakis at chromium.org> wrote:

> On Sat, Sep 1, 2012 at 5:48 PM, Joao Matos <ripzonetriton at gmail.com>wrote:
>
>> Author: triton
>> Date: Sat Sep  1 19:48:08 2012
>> New Revision: 163079
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=163079&view=rev
>> Log:
>> Include the diagnostic introduced in r163078 in a group.
>>
>
>> Modified:
>>     cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
>>
>> Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td?rev=163079&r1=163078&r2=163079&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td (original)
>> +++ cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td Sat Sep  1
>> 19:48:08 2012
>> @@ -1674,8 +1674,7 @@
>>    "\"local-dynamic\", \"initial-exec\" or \"local-exec\"">;
>>  def warn_ms_inheritance_already_declared : Warning<
>>    "ignored since inheritance model was already declared as '"
>> -  "%select{single|multiple|virtual}0'">;
>> -
>> +  "%select{single|multiple|virtual}0'">, InGroup<Microsoft>;
>>
>
> As far as I understand, -Wmicrosoft warns about things that aren't valid
> code which are permitted in microsoft mode. This diagnostic probably
> doesn't belong into this group.
>

Also, please get pre-commit review on patches that aren't obvious -- this
one doesn't seem to be.



>
>>  def err_only_annotate_after_access_spec : Error<
>>    "access specifier can only have annotation attributes">;
>>
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120904/b2ffaac0/attachment.html>