[cfe-commits] [PATCH] Use custom ABIInfo for le32/PNaCl argument codegen

Eli Friedman eli.friedman at gmail.com
Fri Aug 31 15:50:26 PDT 2012


On Fri, Aug 31, 2012 at 9:09 AM, Derek Schuff <dschuff at google.com> wrote:
> There's a document at
> https://sites.google.com/a/chromium.org/dev/nativeclient/pnacl/bitcode-abi
> but all it says currently about calling conventions right now is
> basically what it says in the tests; i.e. pass structs byval and don't
> split or simplify them, 2 inreg params, etc. This patch makes the
> behavior close to the previous behavior (up until before r161022 when
> inreg handling was moved from CodeGenModule::ConstructAttributeList
> into the target-specific ABIInfos). We are actually reviewing this
> part of the spec to better specify it and may make some changes. But
> this patch is a start.
>
> Updated patch attached, thanks.

Looks fine.

-Eli



More information about the cfe-commits mailing list