[cfe-commits] [PATCH] Warn on duplicate const specifier

Aaron Ballman aaron at aaronballman.com
Tue Aug 28 12:56:06 PDT 2012


On Tue, Aug 28, 2012 at 3:06 PM, Chandler Carruth <chandlerc at google.com> wrote:
> I'm a bit uncomfortable making this an ExtWarn in all cases, as it doesn't
> seem like it should be controlled by -pedantic when it is pedantically well
> formed code.
>
> We should probably have two (yea, I know) diagnostics, one for when we
> accept this an an extension, and one for when it is valid but likely
> confusing / inadvisable. I'm happy for them to both be under the same
> diagnostic group though.

Thank you for the feedback (and clarifications).  Here's a revised
patch which splits this into two warnings.  One is an ExtWarn for when
we pedantically allow the behavior.  The other is a vanilla Warning
for when we don't pedantically allow the behavior.  Both are
implemented under the same group.

Thanks!

~Aaron
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dup-spec.patch
Type: application/octet-stream
Size: 4687 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120828/3edb3aaa/attachment.obj>


More information about the cfe-commits mailing list