[cfe-commits] [PATCH] fix PR13704

Matt Beaumont-Gay matthewbg at google.com
Tue Aug 28 09:34:41 PDT 2012


On Mon, Aug 27, 2012 at 8:20 PM, Michael Liao <michael.liao at intel.com> wrote:
> On Mon, 2012-08-27 at 17:07 -0700, Matt Beaumont-Gay wrote:
>> This looks pretty reasonable, but the testcase probably doesn't need
>> to have a printf call in it.
>
> Test case is revised to call an external function instead of printf.
> please let me know whether it's OK to commit.

I assume the extern function could just take an __int128 parameter,
rather than taking a pair of longs and having to jump through hoops to
produce those arguments. What I'm getting at is that the test case
should be as simple as possible.

Anyway, LGTM.

-Matt



More information about the cfe-commits mailing list