[cfe-commits] r162506 - in /cfe/trunk/lib: CodeGen/CGRTTI.cpp Parse/ParseDeclCXX.cpp Parse/ParseExprCXX.cpp Sema/SemaAccess.cpp Serialization/ASTWriter.cpp

David Blaikie dblaikie at gmail.com
Mon Aug 27 14:25:15 PDT 2012


On Thu, Aug 23, 2012 at 5:01 PM, Dmitri Gribenko <gribozavr at gmail.com> wrote:
> Author: gribozavr
> Date: Thu Aug 23 19:01:24 2012
> New Revision: 162506
>
> URL: http://llvm.org/viewvc/llvm-project?rev=162506&view=rev
> Log:
> Fix a few -Wdocumentation warnings.

Are Clang & LLVM generally -Wdocumentation clean?
If you're trying to maintain that invariant, it might be best to add
it to the LLVM Makefiles (see how -Wcovered-switch-default was
conditionally added to the build, perhaps)

- David

>
> Modified:
>     cfe/trunk/lib/CodeGen/CGRTTI.cpp
>     cfe/trunk/lib/Parse/ParseDeclCXX.cpp
>     cfe/trunk/lib/Parse/ParseExprCXX.cpp
>     cfe/trunk/lib/Sema/SemaAccess.cpp
>     cfe/trunk/lib/Serialization/ASTWriter.cpp
>
> Modified: cfe/trunk/lib/CodeGen/CGRTTI.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGRTTI.cpp?rev=162506&r1=162505&r2=162506&view=diff
> ==============================================================================
> --- cfe/trunk/lib/CodeGen/CGRTTI.cpp (original)
> +++ cfe/trunk/lib/CodeGen/CGRTTI.cpp Thu Aug 23 19:01:24 2012
> @@ -105,7 +105,6 @@
>    /// BuildTypeInfo - Build the RTTI type info struct for the given type.
>    ///
>    /// \param Force - true to force the creation of this RTTI value
> -  /// \param ForEH - true if this is for exception handling
>    llvm::Constant *BuildTypeInfo(QualType Ty, bool Force = false);
>  };
>  }
>
> Modified: cfe/trunk/lib/Parse/ParseDeclCXX.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Parse/ParseDeclCXX.cpp?rev=162506&r1=162505&r2=162506&view=diff
> ==============================================================================
> --- cfe/trunk/lib/Parse/ParseDeclCXX.cpp (original)
> +++ cfe/trunk/lib/Parse/ParseDeclCXX.cpp Thu Aug 23 19:01:24 2012
> @@ -2772,9 +2772,6 @@
>  /// This routine should be called when we have finished parsing the
>  /// definition of a class, but have not yet popped the Scope
>  /// associated with the class's definition.
> -///
> -/// \returns true if the class we've popped is a top-level class,
> -/// false otherwise.
>  void Parser::PopParsingClass(Sema::ParsingClassState state) {
>    assert(!ClassStack.empty() && "Mismatched push/pop for class parsing");
>
>
> Modified: cfe/trunk/lib/Parse/ParseExprCXX.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Parse/ParseExprCXX.cpp?rev=162506&r1=162505&r2=162506&view=diff
> ==============================================================================
> --- cfe/trunk/lib/Parse/ParseExprCXX.cpp (original)
> +++ cfe/trunk/lib/Parse/ParseExprCXX.cpp Thu Aug 23 19:01:24 2012
> @@ -1285,11 +1285,11 @@
>  /// [GNU]   type-specifier-seq declarator simple-asm-expr[opt] attributes[opt]
>  ///             '=' assignment-expression
>  ///
> -/// \param ExprResult if the condition was parsed as an expression, the
> -/// parsed expression.
> +/// \param ExprOut if the condition was parsed as an expression, the parsed
> +/// expression.
>  ///
> -/// \param DeclResult if the condition was parsed as a declaration, the
> -/// parsed declaration.
> +/// \param DeclOut if the condition was parsed as a declaration, the parsed
> +/// declaration.
>  ///
>  /// \param Loc The location of the start of the statement that requires this
>  /// condition, e.g., the "for" in a for loop.
> @@ -1766,7 +1766,7 @@
>  ///         ptr-operator conversion-declarator[opt]
>  /// \endcode
>  ///
> -/// \param The nested-name-specifier that preceded this unqualified-id. If
> +/// \param SS The nested-name-specifier that preceded this unqualified-id. If
>  /// non-empty, then we are parsing the unqualified-id of a qualified-id.
>  ///
>  /// \param EnteringContext whether we are entering the scope of the
> @@ -1985,7 +1985,7 @@
>  ///
>  /// \endcode
>  ///
> -/// \param The nested-name-specifier that preceded this unqualified-id. If
> +/// \param SS The nested-name-specifier that preceded this unqualified-id. If
>  /// non-empty, then we are parsing the unqualified-id of a qualified-id.
>  ///
>  /// \param EnteringContext whether we are entering the scope of the
>
> Modified: cfe/trunk/lib/Sema/SemaAccess.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaAccess.cpp?rev=162506&r1=162505&r2=162506&view=diff
> ==============================================================================
> --- cfe/trunk/lib/Sema/SemaAccess.cpp (original)
> +++ cfe/trunk/lib/Sema/SemaAccess.cpp Thu Aug 23 19:01:24 2012
> @@ -1791,7 +1791,7 @@
>  /// specifiers into account, but no member access expressions and such.
>  ///
>  /// \param Decl the declaration to check if it can be accessed
> -/// \param Class the class/context from which to start the search
> +/// \param Ctx the class/context from which to start the search
>  /// \return true if the Decl is accessible from the Class, false otherwise.
>  bool Sema::IsSimplyAccessible(NamedDecl *Decl, DeclContext *Ctx) {
>    if (CXXRecordDecl *Class = dyn_cast<CXXRecordDecl>(Ctx)) {
>
> Modified: cfe/trunk/lib/Serialization/ASTWriter.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Serialization/ASTWriter.cpp?rev=162506&r1=162505&r2=162506&view=diff
> ==============================================================================
> --- cfe/trunk/lib/Serialization/ASTWriter.cpp (original)
> +++ cfe/trunk/lib/Serialization/ASTWriter.cpp Thu Aug 23 19:01:24 2012
> @@ -1329,8 +1329,6 @@
>  /// \brief Write the header search block for the list of files that
>  ///
>  /// \param HS The header search structure to save.
> -///
> -/// \param Chain Whether we're creating a chained AST file.
>  void ASTWriter::WriteHeaderSearch(const HeaderSearch &HS, StringRef isysroot) {
>    SmallVector<const FileEntry *, 16> FilesByUID;
>    HS.getFileMgr().GetUniqueIDMapping(FilesByUID);
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits



More information about the cfe-commits mailing list