[cfe-commits] [PATCH] Rename matchers to better match AST nodes

Sean Silva reviews at llvm-reviews.chandlerc.com
Sun Aug 26 06:55:18 PDT 2012


  If it's not completely consistent, then you lose the ability to say,
  in one sentence "the correspondence is X", which still means you have
  to go back to the docs to look up the correspondence ("is this one of
  the ones that isn't named consistently?").

  I think that it is a case of "premature optimization" to not go all
  the way. Why not "go all the way" and then scale back later if it gets
  to be a pain to write or another issue is found?

  Thanks,

  --Sean Silva

http://llvm-reviews.chandlerc.com/D21



More information about the cfe-commits mailing list