[cfe-commits] r162255 - in /cfe/trunk: include/clang/AST/ExprCXX.h lib/AST/ExprCXX.cpp

[Richard Smith]

Thanks, r162297.

Is there a reason why llvm::RoundUpToAlignment uses a divide and a
multiply, rather than an and? (Is it trying to handle non-power-of-two
alignments?)

On Tue, Aug 21, 2012 at 9:52 AM, Jakob Stoklund Olesen <stoklund at 2pi.dk>wrote:

>
> On Aug 21, 2012, at 9:36 AM, Jordan Rose <jordan_rose at apple.com> wrote:
>
> >
> > On Aug 20, 2012, at 22:42 , Richard Smith <richard-llvm at metafoo.co.uk>
> wrote:
> >
> >> +    ArrayIndexSize = (ArrayIndexSize + Align - 1) & ~(Align - 1);
> >
> > Yuck. Can we put this (and the other time in appears, during allocation)
> in a helper function in AlignOf.h?
>
> MathExtras.h already has RoundUpToAlignment().
>
> /jakob
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120821/d7199445/attachment.html>