[cfe-commits] [clang-tools-extra] r161886 - in /clang-tools-extra/trunk: CMakeLists.txt Makefile toolTemplate/ toolTemplate/CMakeLists.txt toolTemplate/Makefile toolTemplate/ToolTemplate.cpp

[Clow, Marshall]

On Aug 16, 2012, at 8:47 AM, David Blaikie <dblaikie at gmail.com> wrote:
> On Tue, Aug 14, 2012 at 11:53 AM, Marshall Clow <mclow at qualcomm.com> wrote:
>> Author: marshall
>> Date: Tue Aug 14 13:53:39 2012
>> New Revision: 161886
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=161886&view=rev
>> Log:
>> Added a tool template to make creating new tools simpler
>> 
>> Added:
>>    clang-tools-extra/trunk/toolTemplate/
>>    clang-tools-extra/trunk/toolTemplate/CMakeLists.txt
>>    clang-tools-extra/trunk/toolTemplate/Makefile
>>    clang-tools-extra/trunk/toolTemplate/ToolTemplate.cpp
>> Modified:
>>    clang-tools-extra/trunk/CMakeLists.txt
>>    clang-tools-extra/trunk/Makefile

[snip]

>> +//  This file implements an empty refactoring tool using the clang tooling.
>> +//  The goal is to lower the "barrier to entry" for writing refactoring tools.
>> +//
>> +//  Usage:
>> +//  refactoringTemplate <cmake-output-dir> <file1> <file2> ...
> 
> A remnant of the old program name. s/refactoringTemplate/tool-template/ ?

and Manuel Klimek wrote:

>> +  virtual void run(const MatchFinder::MatchResult &Result) {
>> +//  TODO: This routine will get called for each thing that the matchers find.
>> +//  At this point, you can examine the match, and do whatever you want,
>> +//  including replacing the matched text with other text
>> +  }
>> +
>> + private:
>> +  Replacements *Replace;
> 
> This triggers an unused-private-field warning... Do we want to (void)
> use it in run()

Fixed these nits in revision 162031.
Thanks for the hairy eyeballs!

-- Marshall