[cfe-commits] [PATCH] Reverted clang-check to fully supported CommandLine Library use-case: global static variables.

[Alexander Kornienko]

On Thu, Aug 16, 2012 at 7:04 PM, Manuel Klimek <klimek at google.com> wrote:

> On Thu, Aug 16, 2012 at 5:45 PM, Alexander Kornienko <alexfh at google.com>
> wrote:
> > Now it's a bit uglier, but doesn't use CommandLine Library in an
> unsupported
> > way.
> > Chandler, please take a look if it seems better to you.
>
> After a short discussion off-list we came to the conclusion that
> tooling::CommonOptionsParser is a better name for the class, and
> especially makes the responsibilities clearer...
>
A new patch is attached.


>
> > BTW, we still have a number of alien options defined in some llvm
> libraries
> > we link with. Should we try to avoid that by de-globalizing cl library
> or is
> > someone working on its replacement/refactoring now?
>

-- 
Best regards,
Alexander Kornienko
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120816/ae62297d/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tooling-opts.diff
Type: application/octet-stream
Size: 17547 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120816/ae62297d/attachment.obj>