[cfe-commits] [PATCH] Reverted clang-check to fully supported CommandLine Library use-case: global static variables.

Manuel Klimek klimek at google.com
Thu Aug 16 10:04:42 PDT 2012


On Thu, Aug 16, 2012 at 5:45 PM, Alexander Kornienko <alexfh at google.com> wrote:
> Now it's a bit uglier, but doesn't use CommandLine Library in an unsupported
> way.
> Chandler, please take a look if it seems better to you.

After a short discussion off-list we came to the conclusion that
tooling::CommonOptionsParser is a better name for the class, and
especially makes the responsibilities clearer...

> BTW, we still have a number of alien options defined in some llvm libraries
> we link with. Should we try to avoid that by de-globalizing cl library or is
> someone working on its replacement/refactoring now?



More information about the cfe-commits mailing list