[cfe-commits] r161650 - in /cfe/trunk: include/clang/Frontend/VerifyDiagnosticConsumer.h lib/ARCMigrate/ARCMT.cpp lib/Frontend/VerifyDiagnosticConsumer.cpp test/ARCMT/verify.m test/ASTMerge/function.c test/Frontend/verify.c test/Frontend/verify2.c test/Frontend/veri

Andy Gibbs andyg1001 at hotmail.co.uk
Tue Aug 14 10:02:25 PDT 2012


Hi,

Attached is an improvement to the backup checking algorithm that better
supports cling's use-case.

In terms of general operation (i.e. in terms of clang's test-suite), the
functionality is unchanged.  Instead of maintaining two separate lists
for files with diagnostics and those parsed for directives, a single list
is now held, and implemented as a DenseMap with the key as FileID and
the value as a pair of FileEntry* and a bool indicating whether the file
has been parsed for directives or not.

It is important, as stated elsewhere in this thread, to keep FileEntry*
so that FileID aliases can be detected (as is necessary with PCHs, for
example).

The testing I was able to do with cling suggests that the problem there
is now solved.

Jordan, ok to commit?

Cheers
Andy
 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: verify.diff
Type: application/octet-stream
Size: 8934 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120814/999e2565/attachment.obj>


More information about the cfe-commits mailing list