[cfe-commits] r161621 - in /cfe/trunk: include/clang/StaticAnalyzer/Core/PathSensitive/Store.h lib/StaticAnalyzer/Core/ExprEngineC.cpp lib/StaticAnalyzer/Core/Store.cpp test/Analysis/derived-to-base.cpp

[Matt Beaumont-Gay]

Thanks for the quick fix!

On Thu, Aug 9, 2012 at 3:49 PM, Jordan Rose <jordan_rose at apple.com> wrote:
>
> On Aug 9, 2012, at 15:36 , Matt Beaumont-Gay <matthewbg at google.com> wrote:
>
>> On Thu, Aug 9, 2012 at 2:24 PM, Jordan Rose <jordan_rose at apple.com> wrote:
>>>   /// Evaluates DerivedToBase casts.
>>> -  virtual SVal evalDerivedToBase(SVal derived, QualType basePtrType) = 0;
>>> +  virtual SVal evalDerivedToBase(SVal derived, const CastExpr *Cast);
>>> +
>>> +  /// Evaluates a derived-to-base cast through a single level of derivation.
>>> +  virtual SVal evalDerivedToBase(SVal derived, QualType derivedPtrType) = 0;
>>
>> Looks like RegionStoreManager needs to be updated as well? GCC complains thusly:
>> include/clang/StaticAnalyzer/Core/PathSensitive/Store.h:118:16: error:
>> 'virtual clang::ento::SVal
>> clang::ento::StoreManager::evalDerivedToBase(clang::ento::SVal, const
>> clang::CastExpr*)' was hidden [-Werror=overloaded-virtual]
>> lib/StaticAnalyzer/Core/RegionStore.cpp:194:16: error:   by 'virtual
>> clang::ento::SVal
>> {anonymous}::RegionStoreManager::evalDerivedToBase(clang::ento::SVal,
>> clang::QualType)' [-Werror=overloaded-virtual]
>
> Oops, thanks. r161631.