[cfe-commits] pr12328 PATCH: Friend method declaration doesn't require method to be visible

[Stepan Dyatkovskiy]

Yup. Both patched was cleaned and reattached.
-Stepan.

Nikola Smiljanic wrote:
> Hi Stepan,
>
> I can confirm that both patches fix the issue, but I'm in no position
> to review the implementation. I've added John McCall to CC as he seems
> to be the owner of the Access code.
>
> However I do have few nits:
>
> There are two unnecessary spaces at the end of your change in SemaDeclCXX.cpp.
>
> AccessTarget parameter of CheckAccessNow function is not aligned
> properly, you should indent it by two spaces.
>
> The && in the assert condition inside CheckLookupAccessNow should be
> on the previous line, the same probably goes for assert in
> CheckLookupAccess (I'm guessing that you copied code from there :).
>
> Thanks for getting back to this.
>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: pr12328-checknow.patch
Type: text/x-patch
Size: 3323 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120809/e095c843/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pr12328-fixedDD.patch
Type: text/x-patch
Size: 5313 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120809/e095c843/attachment-0001.bin>