[cfe-commits] [Patch 2 of 4] -verify fixes (stage 2)

Andy Gibbs andyg1001 at hotmail.co.uk
Wed Aug 8 23:13:14 PDT 2012


On Thursday, August 09, 2012 3:07 AM, Jordan Rose wrote:
> Hm. This doesn't feel right either, because at this point errRec is no
> longer the actual client hooked up to DiagnosticsEngine. I guess the
> nested begin/end is a better way to go.

As you wish, but errRec is the wrapper around the actual client and is the
diagnostic client in use while the diagnostics are generated.  But I also
prefer the nested approach since it is cleaner and is not necessarily in
conflict with the perceived intention behind the Begin/EndSourceFile calls,
in my opinion.

Cheers
Andy
 



More information about the cfe-commits mailing list