[cfe-commits] r161498 - in /cfe/trunk: tools/arcmt-test/Makefile tools/clang-check/Makefile tools/diagtool/Makefile tools/libclang/Makefile unittests/ASTMatchers/Makefile unittests/Frontend/Makefile unittests/Tooling/Makefile

Chandler Carruth chandlerc at google.com
Wed Aug 8 17:09:23 PDT 2012


LGTM

We may need it in more places, but we can do that iteratively.

No ' ' after the open '(' though: 'set(FOO' is the more common style.

Thanks!


On Wed, Aug 8, 2012 at 5:00 PM, Chad Rosier <mcrosier at apple.com> wrote:

> Chandler,
> How does the attached patch look?
>
>  Chad
>
>
>
>
> On Aug 8, 2012, at 9:32 AM, Chandler Carruth wrote:
>
> CMake? Can I help with those changes?
> On Aug 8, 2012 9:29 AM, "Chad Rosier" <mcrosier at apple.com> wrote:
>
>> Author: mcrosier
>> Date: Wed Aug  8 11:27:29 2012
>> New Revision: 161498
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=161498&view=rev
>> Log:
>> Add various MC components to clang build to support MS-style inline
>> assembly.
>>
>> Modified:
>>     cfe/trunk/tools/arcmt-test/Makefile
>>     cfe/trunk/tools/clang-check/Makefile
>>     cfe/trunk/tools/diagtool/Makefile
>>     cfe/trunk/tools/libclang/Makefile
>>     cfe/trunk/unittests/ASTMatchers/Makefile
>>     cfe/trunk/unittests/Frontend/Makefile
>>     cfe/trunk/unittests/Tooling/Makefile
>>
>> Modified: cfe/trunk/tools/arcmt-test/Makefile
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/arcmt-test/Makefile?rev=161498&r1=161497&r2=161498&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/tools/arcmt-test/Makefile (original)
>> +++ cfe/trunk/tools/arcmt-test/Makefile Wed Aug  8 11:27:29 2012
>> @@ -16,7 +16,8 @@
>>  # Don't install this. It is used for tests.
>>  NO_INSTALL = 1
>>
>> -LINK_COMPONENTS := support mc
>> +include $(CLANG_LEVEL)/../../Makefile.config
>> +LINK_COMPONENTS := $(TARGETS_TO_BUILD) asmparser support mc
>>  USEDLIBS = clangARCMigrate.a clangRewrite.a \
>>                  clangFrontend.a clangDriver.a clangSerialization.a
>> clangParse.a \
>>                  clangSema.a clangEdit.a clangAnalysis.a clangAST.a
>> clangLex.a \
>>
>> Modified: cfe/trunk/tools/clang-check/Makefile
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/clang-check/Makefile?rev=161498&r1=161497&r2=161498&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/tools/clang-check/Makefile (original)
>> +++ cfe/trunk/tools/clang-check/Makefile Wed Aug  8 11:27:29 2012
>> @@ -14,7 +14,8 @@
>>  # No plugins, optimize startup time.
>>  TOOL_NO_EXPORTS = 1
>>
>> -LINK_COMPONENTS := support mc
>> +include $(CLANG_LEVEL)/../../Makefile.config
>> +LINK_COMPONENTS := $(TARGETS_TO_BUILD) asmparser support mc
>>  USEDLIBS = clangFrontend.a clangSerialization.a clangDriver.a \
>>             clangTooling.a clangParse.a clangSema.a clangAnalysis.a \
>>             clangEdit.a clangAST.a clangLex.a clangBasic.a
>>
>> Modified: cfe/trunk/tools/diagtool/Makefile
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/diagtool/Makefile?rev=161498&r1=161497&r2=161498&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/tools/diagtool/Makefile (original)
>> +++ cfe/trunk/tools/diagtool/Makefile Wed Aug  8 11:27:29 2012
>> @@ -16,8 +16,8 @@
>>  # Don't install this.
>>  NO_INSTALL = 1
>>
>> -LINK_COMPONENTS := support mc
>> -
>> +include $(CLANG_LEVEL)/../../Makefile.config
>> +LINK_COMPONENTS := $(TARGETS_TO_BUILD) asmparser support mc
>>  USEDLIBS = clangFrontend.a clangDriver.a clangSerialization.a
>> clangParse.a \
>>             clangSema.a clangAnalysis.a clangEdit.a clangAST.a clangLex.a
>> \
>>             clangBasic.a
>>
>> Modified: cfe/trunk/tools/libclang/Makefile
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/libclang/Makefile?rev=161498&r1=161497&r2=161498&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/tools/libclang/Makefile (original)
>> +++ cfe/trunk/tools/libclang/Makefile Wed Aug  8 11:27:29 2012
>> @@ -15,7 +15,8 @@
>>  LINK_LIBS_IN_SHARED = 1
>>  SHARED_LIBRARY = 1
>>
>> -LINK_COMPONENTS := support mc
>> +include $(CLANG_LEVEL)/../../Makefile.config
>> +LINK_COMPONENTS := $(TARGETS_TO_BUILD) asmparser support mc
>>  USEDLIBS = clangARCMigrate.a clangRewrite.a clangFrontend.a
>> clangDriver.a \
>>       clangSerialization.a \
>>                  clangParse.a clangSema.a clangEdit.a clangAnalysis.a \
>>
>> Modified: cfe/trunk/unittests/ASTMatchers/Makefile
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/ASTMatchers/Makefile?rev=161498&r1=161497&r2=161498&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/unittests/ASTMatchers/Makefile (original)
>> +++ cfe/trunk/unittests/ASTMatchers/Makefile Wed Aug  8 11:27:29 2012
>> @@ -10,7 +10,8 @@
>>  CLANG_LEVEL = ../..
>>
>>  TESTNAME = ASTMatchers
>> -LINK_COMPONENTS := support mc
>> +include $(CLANG_LEVEL)/../../Makefile.config
>> +LINK_COMPONENTS := $(TARGETS_TO_BUILD) asmparser support mc
>>  USEDLIBS = clangTooling.a clangFrontend.a clangSerialization.a
>> clangDriver.a \
>>             clangRewrite.a clangParse.a clangSema.a clangAnalysis.a \
>>             clangAST.a clangASTMatchers.a clangLex.a clangBasic.a
>> clangEdit.a
>>
>> Modified: cfe/trunk/unittests/Frontend/Makefile
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Frontend/Makefile?rev=161498&r1=161497&r2=161498&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/unittests/Frontend/Makefile (original)
>> +++ cfe/trunk/unittests/Frontend/Makefile Wed Aug  8 11:27:29 2012
>> @@ -9,7 +9,8 @@
>>
>>  CLANG_LEVEL = ../..
>>  TESTNAME = Frontend
>> -LINK_COMPONENTS := support mc
>> +include $(CLANG_LEVEL)/../../Makefile.config
>> +LINK_COMPONENTS := $(TARGETS_TO_BUILD) asmparser support mc
>>  USEDLIBS = clangFrontendTool.a clangFrontend.a clangDriver.a \
>>             clangSerialization.a clangCodeGen.a clangParse.a clangSema.a \
>>             clangStaticAnalyzerCheckers.a clangStaticAnalyzerCore.a \
>>
>> Modified: cfe/trunk/unittests/Tooling/Makefile
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Tooling/Makefile?rev=161498&r1=161497&r2=161498&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/unittests/Tooling/Makefile (original)
>> +++ cfe/trunk/unittests/Tooling/Makefile Wed Aug  8 11:27:29 2012
>> @@ -9,7 +9,8 @@
>>
>>  CLANG_LEVEL = ../..
>>  TESTNAME = Tooling
>> -LINK_COMPONENTS := support mc
>> +include $(CLANG_LEVEL)/../../Makefile.config
>> +LINK_COMPONENTS := $(TARGETS_TO_BUILD) asmparser support mc
>>  USEDLIBS = clangTooling.a clangFrontend.a clangSerialization.a
>> clangDriver.a \
>>             clangParse.a clangRewrite.a clangSema.a clangAnalysis.a
>> clangEdit.a \
>>             clangAST.a clangASTMatchers.a clangLex.a clangBasic.a
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120808/62cfb3e5/attachment.html>


More information about the cfe-commits mailing list