[cfe-commits] [patch][libcxx] Fix assertion configuration for CMake builds

Andrew C. Morrow andrew.c.morrow at gmail.com
Sun Aug 5 09:20:03 PDT 2012


Hi -

The current CMake setup for libc++ incorrectly uses the variable
LLVM_ENABLE_ASSERTIONS instead of LIBCXX_ENABLE_ASSERTIONS when
figuring out what _DEBUG/NDEBUG defines to set. It also tries to test
the non-existent variable 'uppercase_CMAKE_BUILD_TYPE', which the top
level LLVM CMakeLists.txt sets up, but which the top level libc++
CMakeLists.txt currently does not. Changing the variable name tested
and creating the uppercase release name variable allows libc++ to
honor the LIBCXX_ENABLE_ASSERTIONS option correctly.

Thanks,
Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libcxx.cmake.asserts.patch
Type: application/octet-stream
Size: 515 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120805/a97c0fdb/attachment.obj>


More information about the cfe-commits mailing list