[cfe-commits] r161194 - /cfe/trunk/test/SemaObjC/arc-dict-bridged-cast.m

[John McCall]

On Aug 2, 2012, at 2:38 PM, Jordan Rose wrote:
> On Aug 2, 2012, at 14:37 , jahanian <fjahanian at apple.com> wrote:
>> On Aug 2, 2012, at 2:23 PM, Jordan Rose wrote:
>> 
>>> How about the other case? Can we avoid offering fixits for transferring globals in and out of ARC? I wouldn't stop a developer from writing it deliberately, but it seems very unlikely to be the correct solution in a case where they just forgot the cast.
>> 
>> Maybe I was not clear. I am using an existing API to decide when to provide fixit and when not. According to ARCCastChecker which enforces the
>> rules, we issue the fix-it warning unless global is in system header file. Please talk to John if you feel this behavior should change.
> 
> Yes, I got that for why the type sucks; this time I was indeed suggesting a change to our heuristics about what's a good possible cast. John?

I'm not totally clear on what you're proposing.  Are you suggesting that we should suggest a non-bridging cast when the source is a "global"?

John.