[cfe-commits] r157352 - in /cfe/trunk/test/Tooling: clang-check-args.cpp multi-jobs.cpp

Manuel Klimek klimek at google.com
Tue Jul 31 09:13:44 PDT 2012


On Tue, Jul 31, 2012 at 5:53 PM, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
> Manuel,
>
> Could you look into them?
>
>> +// FIXME: This is incompatible to -fms-compatibility.
>>  // XFAIL: win32
>
> It is because the intentional error would not be met with -fms-compatibility.
>
>>  // CHECK: C++ requires
>>  invalid;
>
> You could confirm with clang -cc1 -f(no)-ms-compatibllity to tests.
> You may update those intentional errors free from ms-compatibilities.
>
> $ clang -cc1 -fsyntax-only test/Tooling/clang-check-args.cpp
> test/Tooling/clang-check-args.cpp:4:1: error: C++ requires a type
> specifier for all declarations
> invalid;
> ^~~~~~~
> 1 error generated.
>
> $ clang -cc1 -fsyntax-only -fms-compatibility test/Tooling/clang-check-args.cpp
> test/Tooling/clang-check-args.cpp:4:1: warning: type specifier
> missing, defaults to 'int'
> invalid;
> ^~~~~~~
> 1 warning generated.

Do you have a proposal for such an error?
I'm happy to change those...

>
>
> ...Takumi
>
>
> 2012/5/24 NAKAMURA Takumi <geek4civic at gmail.com>:
>> Author: chapuni
>> Date: Wed May 23 17:24:33 2012
>> New Revision: 157352
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=157352&view=rev
>> Log:
>> clang/test/Tooling: Update comments in left 2 tests on XFAIL. They are incompatible to -fms-compatibility.
>>
>> Modified:
>>     cfe/trunk/test/Tooling/clang-check-args.cpp
>>     cfe/trunk/test/Tooling/multi-jobs.cpp
>>
>> Modified: cfe/trunk/test/Tooling/clang-check-args.cpp
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Tooling/clang-check-args.cpp?rev=157352&r1=157351&r2=157352&view=diff
>> ==============================================================================
>> --- cfe/trunk/test/Tooling/clang-check-args.cpp (original)
>> +++ cfe/trunk/test/Tooling/clang-check-args.cpp Wed May 23 17:24:33 2012
>> @@ -3,5 +3,5 @@
>>  // CHECK: C++ requires
>>  invalid;
>>
>> -// FIXME: JSON doesn't like path separator '\', on Win32 hosts.
>> +// FIXME: This is incompatible to -fms-compatibility.
>>  // XFAIL: win32
>>
>> Modified: cfe/trunk/test/Tooling/multi-jobs.cpp
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Tooling/multi-jobs.cpp?rev=157352&r1=157351&r2=157352&view=diff
>> ==============================================================================
>> --- cfe/trunk/test/Tooling/multi-jobs.cpp (original)
>> +++ cfe/trunk/test/Tooling/multi-jobs.cpp Wed May 23 17:24:33 2012
>> @@ -3,5 +3,5 @@
>>  // CHECK: C++ requires
>>  invalid;
>>
>> -// FIXME: JSON doesn't like path separator '\', on Win32 hosts.
>> +// FIXME: This is incompatible to -fms-compatibility.
>>  // XFAIL: win32
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits



More information about the cfe-commits mailing list