[cfe-commits] [PATCH] Fix for syntax checking a header file

Chandler Carruth chandlerc at google.com
Mon Jul 30 17:57:55 PDT 2012

On Mon, Jul 30, 2012 at 5:46 PM, Aaron Ballman <aaron at aaronballman.com>wrote:

> On Mon, Jul 30, 2012 at 8:31 PM, Chandler Carruth <chandlerc at google.com>
> wrote:
> > Why different code from the phases::Compile code right below that handles
> > syntax only? I would expect these to be essentially identical.
> I will admit I'm not too familiar with the driver architecture, but
> since this is applying to a header file, the phase comes in as
> precompile and not compile.  So I figured the special case was what
> made sense, instead of moving C headers to compile phases.

Sorry, all I meant was to structure the code the same way. It would still
be in the Precompile phase...

> > Your test doesn't need '-OPTIONS1' or any suffix -- you only have one
> > compilation.
> >
> > Also, make sure your subversion client submits that new test file with
> > native line endings rather than hard coded MS line endings.
> Fair points.  If the fix is acceptable, I'll correct those on commit.
> ~Aaron
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120730/9dfb1b0f/attachment.html>

More information about the cfe-commits mailing list