[cfe-commits] [PATCH] Diagnose cv-qualified operator new/delete

Jordan Rose jordan_rose at apple.com
Mon Jul 30 13:37:10 PDT 2012


On Jul 30, 2012, at 13:28 , Aaron Ballman <aaron at aaronballman.com> wrote:

> This patch addresses PR13481 so that we properly diagnose overloaded
> operator new and operator delete if it is cv-qualified.

How well does this recover? I think we should just fixit-remove the 'const' or 'volatile' and continue as if the declaration is correct, but it looks like we're actually going to skip the decl pretty much entirely.

Also, the internal warning name has "newdelete" in it, but the text does not. Perhaps this should be used for all static methods, and possibly constructors and destructors as well?

Jordan

P.S. I'm impressed that you picked this up within hours of me filing the bug.



More information about the cfe-commits mailing list