[cfe-commits] [PATCH] Make ASTMatchFinder visit parameter VarDecls

[Manuel Klimek]

On Sun, Jul 29, 2012 at 10:41 AM, Daniel Jasper <djasper at google.com> wrote:
> Hi Manuel,
>
> this fixes a problem of the ASTMatchFinder not visiting the VarDecls of a
> function's parameters (see test case). I am not entirely sure it is the
> right fix as I don't know what the original intention of overriding
> TraverseTypeLoc was.

If I remember correctly, the original problem was that some types were
not visited. With the fix it still looks like the type of the type loc
is not traversed by itself... Not sure why we wouldn't want that in
the RecursiveASTVisitor itself. cc'ing Richard, perhaps he has more
insight here.

Until we have that figured out, I think this is fine to go in, as it's
a strict improvement.

Cheers,
/Manuel