[cfe-commits] [PATCH] don't use _ATTRIBUTE in libc++

[Richard Smith]

On Wed, Jul 25, 2012 at 6:53 PM, Howard Hinnant <hhinnant at apple.com> wrote:

> On Jul 25, 2012, at 9:34 PM, Richard Smith <richard at metafoo.co.uk> wrote:
>
> > Hi,
> >
> > The attached patch switches libc++ from using _ATTRIBUTE(noreturn) to
> _LIBCPP_NORETURN. The former conflicts with a _ATTRIBUTE macro defined
> (differently) by some platform headers. I think that it's not likely to be
> useful to use a general mechanism like this for abstracting out the
> attribute syntax, because many other attributes have name differences as
> well as attribute syntax differences between platforms.
> >
> > OK to commit?
> >
> > Thanks,
> > Richard
> > <libcxx-noreturn.diff>
>
> Yes, thanks for the work, and thanks for checking.
>

Thanks, r160773.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120725/0a84ca57/attachment.html>