[cfe-commits] [PATCH] don't use _ATTRIBUTE in libc++

Richard Smith richard at metafoo.co.uk
Wed Jul 25 18:34:19 PDT 2012


Hi,

The attached patch switches libc++ from using _ATTRIBUTE(noreturn) to
_LIBCPP_NORETURN. The former conflicts with a _ATTRIBUTE macro defined
(differently) by some platform headers. I think that it's not likely to be
useful to use a general mechanism like this for abstracting out the
attribute syntax, because many other attributes have name differences as
well as attribute syntax differences between platforms.

OK to commit?

Thanks,
Richard
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120725/4181c778/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libcxx-noreturn.diff
Type: application/octet-stream
Size: 3789 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120725/4181c778/attachment.obj>


More information about the cfe-commits mailing list