[cfe-commits] Fwd: Compare two DeclGroupRefs

[Vassil Vassilev]

Hi,
On 07/21/2012 12:40 AM, Sean Silva wrote:
> This patch seems to change a lot of lines spuriously, such as
> DeclGroup::Create. Please don't do that, as it makes the patch harder
> to review. To boot, namespaces are generally not indented in the
> LLVM/Clang codebases.
>
> Please review the LLVM Coding Standards
> <http://llvm.org/docs/CodingStandards.html>.
>
>> I am not sure either :) I think it makes sense to compare the sequences of the Decl* and the Decl*'s kinds.
> You should be sure before you submit a patch. If you would like, we
> can discuss how to define equality.
This is what I began with :) I wasn't asking for patch review but for 
how to define equality of two DeclGroupRefs. I just showed my current 
way of doing it.

It appears that this is very much depending on the context of use. 
Perhaps that's why there is no defined == operator.
After thinking for a while it appears that in our use case is good 
enough to compare the opaque ptrs.
Anyway I got my answer. Thanks!

Vassil