[cfe-commits] Fix PR13434 - mangling of templates with function pointers as arguments

[Timur Iskhodzhanov]

Hi Charles, John,

Can you please see
http://llvm.org/bugs/show_bug.cgi?id=13434
?
It seems like this case has never been tested before.

I've written some tests and made a simple fix to the code.

It's not thoroughly tested on all cases but IMO adding at least some
new coverage and making all new tests pass by a simple is a good
progress to start with.

Two questions:
1) See the FIXME comment in MicrosoftMangle - I do think the whole
comment should be made less cryptic.
  Probably I'll need some help from Charles to decipher this :)

2) See the zeta mangling in mangle-ms.cpp - not sure if changing the
mangling there is a problem at all, as "blocks" are never
compiled/mangled by MSVS (they are clang-specific extensions).

Can you please review the patch?

Timur Iskhodzhanov,
Google Russia
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bug_13434.patch
Type: application/octet-stream
Size: 2403 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120723/4b158d9c/attachment.obj>