[cfe-commits] [PATCH] Optimize vec3 loads/stores

Benyei, Guy guy.benyei at intel.com
Thu Jul 19 00:28:07 PDT 2012


Hi Tanya,
I guess the best place to do this would be in somewhere in LLVM - maybe lowering.
Anyhow, your solution would work fine too.

Thanks
    Guy

-----Original Message-----
From: Tanya Lattner [mailto:lattner at apple.com] 
Sent: Thursday, July 19, 2012 03:37
To: Benyei, Guy
Cc: cfe-commits at cs.uiuc.edu
Subject: Re: [cfe-commits] [PATCH] Optimize vec3 loads/stores


On Jul 18, 2012, at 5:08 AM, Benyei, Guy wrote:

> Hi Tanya,
> Looks good and usefull, but I'm not sure if it should be clang's decision if storing and loading vec4s is better than vec3.

The idea was to have Clang generate code that the optimizers would be more likely to do something useful and smart with. I understand the concern, but I'm not sure where the best place for this would be then?

> Anyhow, shouldn't the test check the store shuffle too?
> 

Sure!

-Tanya

> Thanks
>    Guy
> 
> -----Original Message-----
> From: cfe-commits-bounces at cs.uiuc.edu 
> [mailto:cfe-commits-bounces at cs.uiuc.edu] On Behalf Of Tanya Lattner
> Sent: Wednesday, July 18, 2012 01:46
> To: cfe-commits at cs.uiuc.edu
> Subject: [cfe-commits] [PATCH] Optimize vec3 loads/stores
> 
> This patch treats vectors of size 3 like size 4 when loading and store which in turn will cause more optimal code to be emitted by the backend. I've included a test case.
> 
> Please review.
> 
> Thanks,
> Tanya
> 
> ---------------------------------------------------------------------
> Intel Israel (74) Limited
> 
> This e-mail and any attachments may contain confidential material for 
> the sole use of the intended recipient(s). Any review or distribution 
> by others is strictly prohibited. If you are not the intended 
> recipient, please contact the sender and delete all copies.
> 

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.





More information about the cfe-commits mailing list