[cfe-commits] [PATCH] Fix random crasher

Nick Lewycky nlewycky at google.com
Wed Jul 18 16:34:53 PDT 2012


On 18 July 2012 15:55, Robinson, Paul <Paul.Robinson at am.sony.com> wrote:

> Guard use of a possibly uninitialized field.
>
> This was causing very unpredictable compiler crashes. I have not
> provided a test because even our most reliable reproducer still failed
> less than 10% of the time.
>

Can you get a reproducer that reliably triggers a valgrind notice? Can you
produce a reduced testcase which does that?

Nick

I really really really don't like sometimes-uninitialized fields
> guarded by flags. It is not a robust practice and took us a couple of
> weeks of poking at it to find the root cause. But it is how the rest
> of SemaOverload handles this field, so we fixed it using the
> prevailing practice in the module.
> --paulr
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120718/f341ed90/attachment.html>


More information about the cfe-commits mailing list