[cfe-commits] [Differential] D4: Hooks for custom CompilationDatabase

Manuel Klimek klimek at google.com
Thu Jul 12 00:23:34 PDT 2012

On Wed, Jul 11, 2012 at 10:30 PM, John McCall <rjmccall at apple.com> wrote:
> Could you guys work on the email output of this so that it's more person-friendly?
> In particular, crap like this:
>     djasper updated the revision "Hooks for custom CompilationDatabase".
> 1) does not need to be at the top of the message and
> 2) has all of its content implied by the email headers anyway.
> It seems to me like a comment on a patch should come out as an unadorned
> message, ideally with some quoted history.  A new patch, or a revision on a
> patch, can have more introductory verbiage, although again it doesn't really
> seem necessary;  just the patch description followed by the patch would be
> great.
> Also, I do not care about your username on the review system;  please take it
> out of the From: header.

Thanks for the feedback. This is in line with our own thoughts, so
it's good to hear that we're focusing on the right things :)

E-Mail is one of the hard-to-get right parts, and we'll work on making
it look&feel as much as normal email as possible. We've also found
some other quirks in the email handling during our testing, and we'll
work on getting those resolved before testing again.

Thx for bearing with us & sorry for any inconvenience this caused...


More information about the cfe-commits mailing list