[cfe-commits] Evaluating a code review tool for clang/llvm: phabricator

Chandler Carruth chandlerc at google.com
Wed Jul 11 14:59:12 PDT 2012


On Wed, Jul 11, 2012 at 2:44 PM, Sean Silva <silvas at purdue.edu> wrote:

> Do you know if it is within phabricator's scope to notify you about
> patches/commits that are in parts of the code that you're "interested
> in watching"?


Yes, this is specifically supported, and one of the reasons we're
particularly interested in this toolset.


> This functionality is primarily to help developers
> prioritize their code review time and make sure that they don't miss
> patches relevant to them. Currently with the mailing lists, it is
> difficult to filter patches/commits like this, and it seems like an
> external tool is necessary.
>

Exactly. It also supports automated "audits" and concepts such as code
owners.

And all of this works for post-commit as well as pre-commit.

If the review process is suitable to the community, Manuel and I are
interested in helping set up (and fix) these tools to closely match the
existing community practices and expectations regarding post commit review
and code ownership.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120711/58673e7f/attachment.html>


More information about the cfe-commits mailing list