[cfe-commits] [patch] Default to -std=c++11 on windows

[Richard Smith]

Is there a reason to put the change there rather than in
CompilerInvocation::setLangDefaults? It seems like this would do the wrong
thing for tools which don't use the driver.

On Wed, Jul 11, 2012 at 9:28 AM, Chandler Carruth <chandlerc at google.com>wrote:

> LGTM.
>
> It would be good to document this behavior somewhere.
>
>
> On Wed, Jul 11, 2012 at 9:21 AM, Nico Weber <thakis at chromium.org> wrote:
>
>> Hi,
>>
>> the attached patch lets clang default to -std=c++11 on windows, as
>> discussed on this list previously.
>>
>> This could be done in either the driver or in the frontend, both
>> currently do some language standard processing. A comment in
>> lib/Driver/Tools.cpp (2 lines above my patch) suggests that eventually
>> all this code should move to the driver, so that's where I put my
>> change.
>>
>> This could also keyed off various things. I settled on comparing the
>> triple's OS to llvm::Triple::Win32, since that's what enables
>> -fms-compatibility by default too.
>>
>> Ok?
>>
>> Nico
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120711/7b922038/attachment.html>