[cfe-commits] [Windows] Use thiscall as the default calling convention for class methods

John McCall rjmccall at apple.com
Wed Jul 11 10:57:55 PDT 2012


On Jul 11, 2012, at 5:34 AM, Timur Iskhodzhanov wrote:
> With the attached patch the cdecl test passes now.
> 
> However, I'm not very sure what I'm doing here and why it doesn't work
> in the first place - can you please take a look?

Hmm.  The problem here is that getCanonicalCallConv is turning CC_C
into CC_Default.  That needs to be disabled in Microsoft mode, just like
it apparently is in MRTD mode.

...also, the way that MRTD mode is implemented is wrong, and we should
be handling this in IR-generation the same that we're handling the
thiscall rules.

John.



More information about the cfe-commits mailing list