[cfe-commits] r159592 - /cfe/trunk/lib/Driver/Driver.cpp

David Blaikie dblaikie at gmail.com
Mon Jul 2 14:28:00 PDT 2012


Author: dblaikie
Date: Mon Jul  2 16:28:00 2012
New Revision: 159592

URL: http://llvm.org/viewvc/llvm-project?rev=159592&view=rev
Log:
Include -D files in crash report repro scripts. (PR13255)

Now that we're only using -frewrite-includes rather than full preprocessing
when producing repro source files, we should also include command line macro
definitions in the repro script.

I don't have a test case for this because I'm not sure if/how I can open the
crash report file when the name is only known by scraping the crash report
output. Suggestions welcome if anyone thinks it'd be helpful.

Modified:
    cfe/trunk/lib/Driver/Driver.cpp

Modified: cfe/trunk/lib/Driver/Driver.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Driver.cpp?rev=159592&r1=159591&r2=159592&view=diff
==============================================================================
--- cfe/trunk/lib/Driver/Driver.cpp (original)
+++ cfe/trunk/lib/Driver/Driver.cpp Mon Jul  2 16:28:00 2012
@@ -503,7 +503,6 @@
         // Strip away options not necessary to reproduce the crash.
         // FIXME: This doesn't work with quotes (e.g., -D "foo bar").
         SmallVector<std::string, 16> Flag;
-        Flag.push_back("-D ");
         Flag.push_back("-F");
         Flag.push_back("-I ");
         Flag.push_back("-o ");





More information about the cfe-commits mailing list