[cfe-commits] [llvm-commits] [PATCH] Add support for MIPS DSP Rev1 intrinsics to the Clang frontend

Simon Atanasyan satanasyan at mips.com
Thu Jun 28 11:30:22 PDT 2012


On Wed, Jun 27, 2012 at 9:19 PM, Jim Grosbach <grosbach at apple.com> wrote:
> LGTM.
>
> As a very mild stylistic note, you have 'let TargetPrefix = "mips"' for each section in the IntrinsicsMips.td. I suggest just putting that in once surround everything and reducing the indentation level of everything inside it, just like we do for large namespaces in C++ code.

Thanks for review. I applied suggested changes and submitted patches
at r159364 and r159366.

--
Simon




More information about the cfe-commits mailing list