[cfe-commits] [patch] Added a suggestion when a std::string is passed to printf()

Chandler Carruth chandlerc at google.com
Fri Jun 22 17:00:23 PDT 2012


On Fri, Jun 22, 2012 at 4:57 PM, Matt Beaumont-Gay <matthewbg at google.com>wrote:

> On Fri, Jun 22, 2012 at 4:51 PM, Chandler Carruth <chandlerc at google.com>
> wrote:
> > On Fri, Jun 22, 2012 at 4:21 PM, Sam Panzer <panzer at google.com> wrote:
> >>
> >> This has been fixed in the attached patch, which will look nearly
> >> identical as the only change was to move a return statement out of one
> >> enclosing if-else block.
> >
> >
> > Did you add a test case to cover this case?
>
> Rafael added a test case when he reverted the original.
>

Lovely! =D


>
> -Matt
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120622/6daf2750/attachment.html>


More information about the cfe-commits mailing list