[cfe-commits] r158833 - in /cfe/trunk: include/clang/Basic/DiagnosticSemaKinds.td lib/CodeGen/CGStmt.cpp lib/Sema/SemaStmt.cpp test/Parser/MicrosoftExtensions.c test/Parser/ms-inline-asm.c

[Chris Lattner]

On Jun 20, 2012, at 11:28 AM, Chad Rosier wrote:

> Author: mcrosier
> Date: Wed Jun 20 13:28:37 2012
> New Revision: 158833
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=158833&view=rev
> Log:
> [ms-style asm] Change the fatal error to an extension warning.  Apparently, this
> error was asserting on anything that included Windows.h.  MS-style inline asm is
> still dropped, but at least now we're not completely silent about it.

In the ARC project we had a similar issue, where "invalid" code was used in headers in decls that were never used in code.  We settled on implicitly marking the containing decls (usually structs in ARC's case, but functions would also be possible) as attribute(unavailable, "this isn't available in ARC").

It probably isn't worth doing this given how broken ms-asm was before, and that you're likely to just implement it... but it's an option :)

-Chris