[cfe-commits] r158851 - /cfe/trunk/include/clang/Analysis/CallGraph.h

[Douglas Gregor]

On Jun 20, 2012, at 1:57 PM, Anna Zaks <ganna at apple.com> wrote:

> Author: zaks
> Date: Wed Jun 20 15:57:49 2012
> New Revision: 158851
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=158851&view=rev
> Log:
> [analyzer] Do not walk the types for call graph construction.
> 
> Similar to r156661. This should be beneficial performance wise and
> hopefully, resolve a RecursiveASTVisitor crash that we are seeing in the
> wild, but are incapable of reproducing.

There could actually be interesting control flow in variably-modified types (e.g., VLAs). Should this be disabled only for types that aren't variably modified?

	- Doug


> Modified:
>    cfe/trunk/include/clang/Analysis/CallGraph.h
> 
> Modified: cfe/trunk/include/clang/Analysis/CallGraph.h
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Analysis/CallGraph.h?rev=158851&r1=158850&r2=158851&view=diff
> ==============================================================================
> --- cfe/trunk/include/clang/Analysis/CallGraph.h (original)
> +++ cfe/trunk/include/clang/Analysis/CallGraph.h Wed Jun 20 15:57:49 2012
> @@ -121,6 +121,8 @@
>     return true;
>   }
> 
> +  bool shouldWalkTypesOfTypeLocs() const { return false; }
> +
> private:
>   /// \brief Add the given declaration to the call graph.
>   void addNodeForDecl(Decl *D, bool IsGlobal);
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits