[cfe-commits] r158777 - /cfe/trunk/lib/Comments/CMakeLists.txt

[Chandler Carruth]

On Tue, Jun 19, 2012 at 6:20 PM, Dmitri Gribenko <gribozavr at gmail.com>wrote:

> On Tue, Jun 19, 2012 at 6:06 PM, Rafael Espíndola
> <rafael.espindola at gmail.com> wrote:
> > I am still getting:
> >
> > FAILED: : && /home/espindola/inst/clang/bin/clang++
> > -fcolor-diagnostics  -fPIC -fvisibility-inlines-hidden -fno-common
> > -Woverloaded-virtual -Wcast-qual -fno-strict-aliasing -pedantic
> > -Wno-long-long -Wall -W -Wno-unused-parameter -Wwrite-strings
> > -fno-rtti -fPIC
> > tools/clang/tools/diagtool/CMakeFiles/diagtool.dir/diagtool_main.cpp.o
> > tools/clang/tools/diagtool/CMakeFiles/diagtool.dir/DiagTool.cpp.o
> > tools/clang/tools/diagtool/CMakeFiles/diagtool.dir/DiagnosticNames.cpp.o
> > tools/clang/tools/diagtool/CMakeFiles/diagtool.dir/ListWarnings.cpp.o
> >
> tools/clang/tools/diagtool/CMakeFiles/diagtool.dir/ShowEnabledWarnings.cpp.o
> >  -o bin/diagtool -rdynamic lib/libclangBasic.a lib/libclangComments.a
> > lib/libclangLex.a lib/libclangSema.a lib/libclangFrontend.a
> > lib/libLLVMSupport.a -ldl -lpthread lib/libclangDriver.a
> > lib/libclangParse.a lib/libclangSerialization.a lib/libclangSema.a
> > lib/libclangAnalysis.a lib/libclangEdit.a lib/libclangAST.a
> > lib/libclangLex.a lib/libclangBasic.a lib/libLLVMMC.a
> > lib/libLLVMObject.a lib/libLLVMSupport.a -ldl -lpthread && :
> >
> lib/libclangSema.a(Sema.cpp.o):/home/espindola/llvm/llvm/tools/clang/lib/Sema/Sema.cpp:function
> > clang::Sema::ActOnComment(clang::SourceRange): error: undefined
> > reference to 'clang::RawComment::RawComment(clang::SourceManager
> > const&, clang::SourceRange, bool)'
> >
> lib/libclangSema.a(Sema.cpp.o):/home/espindola/llvm/llvm/tools/clang/lib/Sema/Sema.cpp:function
> > clang::Sema::ActOnComment(clang::SourceRange): error: undefined
> > reference to 'clang::RawCommentList::addComment(clang::RawComment
> > const&, clang::ASTContext&)'
>
> I'm sorry, but CMake build is working for me (on Darwin).
> Is this because libclangComments.a is before libclangSema.a?  Will
> shuffling libraries in tools/diagtool/CMakeLists.txt help?
>

It's definitely still failing on Linux. This is likely due to a cyclic
dependency that Darwin's linker is managing to resolve, but Linux's is not.
I'll look into this more as well, but I would look for dependencies added
by your change between libraries that were not there previously. There may
be a layering violation in your patch.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120619/cfed3617/attachment.html>