[cfe-commits] r158700 - in /cfe/trunk: include/clang/Basic/Attr.td include/clang/Sema/AttributeList.h lib/AST/ExprCXX.cpp lib/Lex/PPMacroExpansion.cpp lib/Parse/ParseDecl.cpp lib/Parse/ParseDeclCXX.cpp lib/Sema/DeclSpec.cpp lib/Sema/SemaDeclAttr.

[Aaron Ballman]

On Tue, Jun 19, 2012 at 5:29 PM, Howard Hinnant <hhinnant at apple.com> wrote:
> On Jun 19, 2012, at 6:11 PM, Aaron Ballman wrote:
>
>> On Tue, Jun 19, 2012 at 5:09 PM, Howard Hinnant <hhinnant at apple.com> wrote:
>>> On Jun 19, 2012, at 5:52 PM, Jakob Stoklund Olesen wrote:
>>>
>>>>
>>>> On Jun 19, 2012, at 10:27 AM, Howard Hinnant <hhinnant at apple.com> wrote:
>>>>
>>>>> I'm also seeing a new failure in libcxx/test/language.support/support.exception/except.nested/rethrow_if_nested.pass.cpp:
>>>>>
>>>>> Assertion failed: (false), function main, file rethrow_if_nested.pass.cpp, line 69.
>>>>>
>>>>> I'm not positive it is this patch.  But there aren't many patches since the last successful test:
>>>>>
>>>>> http://llvm.org/viewvc/llvm-project?view=rev&revision=158698
>>>>> http://llvm.org/viewvc/llvm-project?view=rev&revision=158699
>>>>> http://llvm.org/viewvc/llvm-project?view=rev&revision=158700
>>>>> http://llvm.org/viewvc/llvm-project?view=rev&revision=158701
>>>>>
>>>>> Howard
>>>>
>>>> I reverted r158700 and dependent patches after verifying it caused the crash in g++.abi/vtable3a.C.
>>>
>>> I've confirmed libcxx/test/language.support/support.exception/except.nested/rethrow_if_nested.pass.cpp is now passing.
>>
>> Can you try again?  I've reapplied my dependent patch (it compiled
>> cleanly and passed my local tests), but want to be sure.
>
> Yes, still works.  Thanks for checking.

Phew!  ;-)  Thanks for the help.

~Aaron