[cfe-commits] [PATCH] Refactor some utility functions from DiagnosticRenderer.cpp into SourceManager

Matt Beaumont-Gay matthewbg at google.com
Mon Jun 18 13:19:06 PDT 2012


Thanks, r158676.

On Sat, Jun 16, 2012 at 1:55 AM, Manuel Klimek <klimek at google.com> wrote:
> Nice! We can use that on the tooling side :) (looks good as far as I can
> tell)
>
> On Sat, Jun 16, 2012 at 3:24 AM, Matt Beaumont-Gay <matthewbg at google.com>
> wrote:
>>
>> Simple refactoring, no functionality change. My use case is getting
>> better PresumedLocs in my (out-of-tree) specialized diagnostic client;
>> I suspect there may be others who will find one or more of these
>> useful. I renamed getDiagnosticPresumedLoc to
>> getPresumedLocForDisplay; better suggestions there or wordsmithing on
>> the doxyment would be appreciated.
>>
>> -Matt
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>



More information about the cfe-commits mailing list