[cfe-commits] [PATCH] Automatically handle parsing of attribute namespaces.

Richard Smith richard at metafoo.co.uk
Fri Jun 15 14:37:53 PDT 2012


Hi Sean,

On Fri, Jun 15, 2012 at 2:07 PM, Sean Hunt <scshunt at csclub.uwaterloo.ca> wrote:
> On the basis that the code should be self-descriptive, no description.

Is the diff missing part of the patch sequence?

--- a/lib/Sema/AttributeList.cpp
+++ b/lib/Sema/AttributeList.cpp
@@ -109,10 +111,13 @@ AttributeList::Kind AttributeList::getKind(const
IdentifierInfo *Name,
       AttrName.size() >= 4)
     AttrName = AttrName.substr(2, AttrName.size() - 4);

-  // FIXME: implement attribute namespacing correctly.
   SmallString<64> Buf;
   if (ScopeName)
-    (Buf += ScopeName->getName()) += "::";

This doesn't match the code in my checkout.



More information about the cfe-commits mailing list