[cfe-commits] [patch] rewrite-includes crash support

David Blaikie dblaikie at gmail.com
Wed Jun 13 16:57:26 PDT 2012

Sending this for review because it has a few different changes in
areas I'm less familiar with (driver) though they're mostly
mechanical. Each one's probably OK for post-commit review, but I
didn't want to spam the commit queue & then find review feedback for
the first one that would interfere with the later patches & all get a
bit messy.

The changes included are:

Rename -rewrite-includes to -frewrite-includes
Support -frewrite-includes as an option while preprocessing, rather
than as a flag of its own
Support -f[no-]rewrite-includes from the driver.
Fix crash in -frewrite-includes when a #include specified a file that
could not be found.
>>Use -frewrite-includes for crash reports.<<

I've included a test case for the crash (item 4), but not the crash
reporting itself (I'm happy to do so but haven't looked at whether we
have any direct testing of this scenario) nor the driver flag support
(seemed mechanical/silly to test -fno-x overrides -fx, etc - correct
me if I'm wrong).

- David
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rewrite_includes.diff
Type: application/octet-stream
Size: 21256 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120613/37c4b884/attachment.obj>

More information about the cfe-commits mailing list