[cfe-commits] [PATCH 4/4] [clang.py] Implement Cursor.is_static_method

Gregory Szorc gregory.szorc at gmail.com
Sat Jun 9 09:24:06 PDT 2012

On 5/14/12 10:31 AM, Hans Wennborg wrote:
> On Mon, May 14, 2012 at 4:46 AM, Gregory Szorc <gregory.szorc at gmail.com> wrote:
>> On 5/13/12 1:19 AM, Manuel Klimek wrote:
>>> +        Returns True if it is or False if not or if the Cursor does
>>> not refer
>>> +        to a function template declaration or method declaration.
>>> This took me a while to parse... So two things: first, shouldn't that
>>> be "member function template"?
>> I don't know!
>>> Second, how about: "Returns whether the Cursor refers to a static
>>> member function template or method declaration."
>> Yeah, it is hard to read. I'll update the description.
>>> I'm also not quite sure whether all this is necessary, and "method" is
>>> not good enough to describe the intent here, but my C++-foo is
>>> probably not good enough for that argument.
>> Perhaps someone who knows the C++ terminology could weigh in here.
> Looking at clang_CXXMethod_isStatic in include/clang-c/Index.h, that
> says "Determine if a C++ member function or member function template
> is declared 'static'."
> So maybe something like: "Returns true if the cursor refers to a C++
> member function or member function template that is declared
> 'static'."?

I committed with Hans' wording.

Committing to https://llvm.org/svn/llvm-project/cfe/trunk ...
	M	bindings/python/clang/cindex.py
	M	bindings/python/tests/cindex/test_cursor.py
Committed r158277

More information about the cfe-commits mailing list